tracing/tracing/extras/tquery/tquery.html - Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/tquery/tquery.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix break/continue Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« perf_insights/perf_insights/mappers/thread_grouping_test.html ('K') | « perf_insights/perf_insights/mappers/v8_map_function.html ('k') | tracing/tracing/importer/find_input_expectations.html » ('j') | tracing/tracing/metrics/system_health/first_paint_metric.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/extras/tquery/tquery.html

diff --git a/tracing/tracing/extras/tquery/tquery.html b/tracing/tracing/extras/tquery/tquery.html

index 8953d7e9bddd2aee6770e8ba8dab11432780f757..9101abbe0df5e6b98b300e7c7caaadc644ebf4ab 100644

--- a/tracing/tracing/extras/tquery/tquery.html

+++ b/tracing/tracing/extras/tquery/tquery.html

@@ -147,13 +147,12 @@ tr.exportTo('tr.e.tquery', function() {

// model.

selectEverythingAsTask_: function(selection) {

var filterTask = new tr.b.Task();

- this.model_.iterateAllEventContainers(function(container) {

- filterTask.subTask(function() {

- container.iterateAllEventsInThisContainer(

- function() { return true; },

- addEventTreeToSelection.bind(undefined, selection));

+ for (var container of this.model_.descendantEventContainers()) {

+ filterTask.subTask(() => {

+ for (var event of container.childEvents())

+ addEventTreeToSelection(selection, event);

}, this);

- }, this);

+ }

return filterTask;