perf_insights/perf_insights/mappers/thread_grouping_test.html - Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf_insights/perf_insights/mappers/thread_grouping_test.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix break/continue Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« perf_insights/perf_insights/mappers/scheduling/map_input_blockers.html ('K') | « perf_insights/perf_insights/mappers/slice_cost.html ('k') | perf_insights/perf_insights/mappers/trace_import_cost.html » ('j') | tracing/tracing/metrics/system_health/first_paint_metric.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: perf_insights/perf_insights/mappers/thread_grouping_test.html

diff --git a/perf_insights/perf_insights/mappers/thread_grouping_test.html b/perf_insights/perf_insights/mappers/thread_grouping_test.html

index 59b3bedba21a001de74636df2d264ba5bc885ed4..dff08455dd55f29a3804bb6d453bc6a4e1d6baf9 100644

--- a/perf_insights/perf_insights/mappers/thread_grouping_test.html

+++ b/perf_insights/perf_insights/mappers/thread_grouping_test.html

@@ -41,10 +41,10 @@ tr.b.unittest.testSuite(function() {

tg.autoInitUsingHelpers(m);

var allSlices = new tr.model.EventSet();

- m.iterateAllEvents(function(e) {

+ for (var e of m.descendantEvents()) {

charliea (OOO until 10-5) 2016/06/29 18:08:44 nit: no need for braces here

alexandermont 2016/06/29 20:47:11 Done

if (e instanceof tr.model.Slice)

allSlices.push(e);

- });

+ }

var groups = tg.divideEventSetIntoSubGroups(allSlices);

var numGrouped = 0;

tr.b.iterItems(groups, function(groupName, eventSet) {