Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix break/continue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html
diff --git a/perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html b/perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html
index f601f04d644a9e7660989c00baffdeb0793b934b..f751470c9351dc7f350ed0dd421fcb93a20d39f9 100644
--- a/perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html
+++ b/perf_insights/perf_insights/mappers/scheduling/map_rendering_cost.html
@@ -48,14 +48,14 @@ tr.exportTo('pie', function() {
for (var pid in rendererHelpers) {
var rendererHelper = rendererHelpers[pid];
var mainThread = rendererHelper.mainThread;
- mainThread.iterateAllEvents(function(event) {
+ for (var event of mainThread.descendantEvents()) {
// Look for tasks executed by the scheduler. Note that this only
// includes slices that are *completely* inside the loading phase.
if (event.title !== 'TaskQueueManager::RunTask' ||
event.start < loadingEvent.start ||
event.start + event.duration >
loadingEvent.start + loadingEvent.duration) {
- return;
+ continue;
}
totalCost += eventCost(event);
@@ -65,7 +65,7 @@ tr.exportTo('pie', function() {
beginMainFrameCount++;
beginMainFrameCost += eventCost(beginMainFrame);
}
- });
+ }
}
loadingTotalCost[index] = totalCost;

Powered by Google App Engine
This is Rietveld 408576698