Issue 20832002: Revert "Revert "Turn on i18n support in V8.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20832002: Revert "Revert "Turn on i18n support in V8."" (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 4 months ago

Reviewers:
danno

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Revert "Turn on i18n support in V8."" > This reverts r213418 as it caused Blink LayoutTest failures: > fast/js/kde/inbuilt_function_tostring.html > fast/workers/stress-js-execution.html > > The crash in stress-js-execution looks particularly bad, as it > crashes with a CHECK failure about mismatched isolates (suggesting > that we're on the wrong thread). > > BUG=v8:2745 > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/19476008 TBR=danno@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214115

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r214115 (presubmit successful).

7 years, 4 months ago (2013-07-28 08:59:57 UTC) #1

Message was sent while issue was closed.

lgtm