Issue 19476008: Revert "Turn on i18n support in V8."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19476008: Revert "Turn on i18n support in V8." (Closed)

Created:
7 years, 5 months ago by adamk

Modified:
7 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, danno

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Turn on i18n support in V8." This reverts r213418 as it caused Blink LayoutTest failures: fast/js/kde/inbuilt_function_tostring.html fast/workers/stress-js-execution.html The crash in stress-js-execution looks particularly bad, as it crashes with a CHECK failure about mismatched isolates (suggesting that we're on the wrong thread). BUG=v8:2745 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213501

Patch Set 1 #

Patch Set 2 : Upload again #

Patch Set 3 : Upload again #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	build/common.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/19476008/7001

7 years, 5 months ago (2013-07-24 18:34:33 UTC) #2

adamk

7 years, 5 months ago (2013-07-24 20:24:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r213501 (presubmit successful).

Expand Messages | Collapse Messages