Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Unified Diff: Source/modules/filesystem/SyncCallbackHelper.h

Issue 208313010: Replace raw pointers to GC allocated objects by members in stack allocated objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/filesystem/SyncCallbackHelper.h
diff --git a/Source/modules/filesystem/SyncCallbackHelper.h b/Source/modules/filesystem/SyncCallbackHelper.h
index 00aa746fdb46ad018c409f1e581b181bca07b13f..c73da5f68aab9f4251473c3a4571ec81ffb121e3 100644
--- a/Source/modules/filesystem/SyncCallbackHelper.h
+++ b/Source/modules/filesystem/SyncCallbackHelper.h
@@ -54,7 +54,7 @@ struct HelperResultType {
DISALLOW_ALLOCATION();
public:
typedef PassRefPtrWillBeRawPtr<ResultType> ReturnType;
- typedef RefPtrWillBeRawPtr<ResultType> StorageType;
+ typedef RefPtrWillBeMember<ResultType> StorageType;
static ReturnType createFromCallbackArg(CallbackArg argument)
{
@@ -154,7 +154,7 @@ private:
bool m_completed;
};
-struct EmptyType : public RefCounted<EmptyType> {
+struct EmptyType : public RefCountedWillBeGarbageCollected<EmptyType> {
haraken 2014/03/24 07:05:03 I don't know why this change is needed, but it loo
zerny-chromium 2014/03/24 08:32:28 We can't put non-GC allocated types in members as
static PassRefPtrWillBeRawPtr<EmptyType> create(EmptyType*)
{
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698