Replace raw pointers to GC allocated objects by members in stack allocated objects.

Source/modules/filesystem/SyncCallbackHelper.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 36 matching lines @@
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 template <typename ResultType, typename CallbackArg>
 struct HelperResultType {
     DISALLOW_ALLOCATION();
 public:
     typedef PassRefPtrWillBeRawPtr<ResultType> ReturnType;
-    typedef RefPtrWillBeRawPtr<ResultType> StorageType;
+    typedef RefPtrWillBeMember<ResultType> StorageType;
 
     static ReturnType createFromCallbackArg(CallbackArg argument)
     {
         return ResultType::create(argument);
     }
 };
 
 // A helper template for FileSystemSync implementation.
 template <typename SuccessCallback, typename CallbackArg, typename ResultType>
 class SyncCallbackHelper {
@@ skipping 79 matching lines @@
     {
         m_result = ResultTypeTrait::createFromCallbackArg(result);
         m_completed = true;
     }
 
     ResultStorageType m_result;
     FileError::ErrorCode m_errorCode;
     bool m_completed;
 };
 
-struct EmptyType : public RefCounted<EmptyType> {
+struct EmptyType : public RefCountedWillBeGarbageCollected<EmptyType> {

[haraken, 2014/03/24 07:05:03]

I don't know why this change is needed, but it looks OK.

[zerny-chromium, 2014/03/24 08:32:28]

We can't put non-GC allocated types in members as statically asserted in the
Member constructors.

     static PassRefPtrWillBeRawPtr<EmptyType> create(EmptyType*)
     {
         return nullptr;
     }
 };
 
 typedef SyncCallbackHelper<EntryCallback, Entry*, EntrySync> EntrySyncCallbackHelper;
 typedef SyncCallbackHelper<MetadataCallback, Metadata*, Metadata> MetadataSyncCallbackHelper;
 typedef SyncCallbackHelper<VoidCallback, EmptyType*, EmptyType> VoidSyncCallbackHelper;
 typedef SyncCallbackHelper<FileSystemCallback, DOMFileSystem*, DOMFileSystemSync> FileSystemSyncCallbackHelper;
 
 } // namespace WebCore
 
 #endif // SyncCallbackHelper_h