Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 208313002: Revert of Minor fix to regex inside compiler_version.py (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico, Inactive
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Minor fix to regex inside compiler_version.py (https://codereview.chromium.org/207303004/) Reason for revert: The second \. should have remained a . Chris Dumez 1 minute ago #7 Message was sent while issue was closed. https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py#ne... build/compiler_version.py:31: version_re = re.compile(r"^GNU [^ ]+ .* (\d+)\.(\d+)\.*?$", re.M) The last "\.*" looks weird, I think it should be ".*" Original issue's description: > Minor fix to regex inside compiler_version.py > > These dots where meant to be literal dots, not anything. > > BUG=352046 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258570 TBR=thakis@chromium.org,thestig@chromium.org,ch.dumez@samsung.com NOTREECHECKS=true NOTRY=true BUG=352046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/compiler_version.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mithro-old
Created Revert of Minor fix to regex inside compiler_version.py
6 years, 9 months ago (2014-03-21 14:48:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/208313002/1
6 years, 9 months ago (2014-03-21 14:48:09 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 14:48:40 UTC) #3
Message was sent while issue was closed.
Change committed as 258579

Powered by Google App Engine
This is Rietveld 408576698