DescriptionRevert of Minor fix to regex inside compiler_version.py (https://codereview.chromium.org/207303004/)
Reason for revert:
The second \. should have remained a .
Chris Dumez
1 minute ago #7
Message was sent while issue was closed.
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py
File build/compiler_version.py (right):
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py#ne...
build/compiler_version.py:31: version_re = re.compile(r"^GNU [^ ]+ .*
(\d+)\.(\d+)\.*?$", re.M)
The last "\.*" looks weird, I think it should be ".*"
Original issue's description:
> Minor fix to regex inside compiler_version.py
>
> These dots where meant to be literal dots, not anything.
>
> BUG=352046
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258570
TBR=thakis@chromium.org,thestig@chromium.org,ch.dumez@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=352046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258579
Patch Set 1 #
Created: 6 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|