build/compiler_version.py - Issue 208313002: Revert of Minor fix to regex inside compiler_version.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/compiler_version.py

Issue 208313002: Revert of Minor fix to regex inside compiler_version.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/compiler_version.py

diff --git a/build/compiler_version.py b/build/compiler_version.py

index 22785e5ae2ee9dd8498698e31943b9e5ad1b1c31..b06712d25b2d3c25990a97f99a630a66c703ce0b 100755

--- a/build/compiler_version.py

+++ b/build/compiler_version.py

@@ -28,7 +28,7 @@

# Unmodified: GNU assembler (GNU Binutils) 2.24

# Ubuntu: GNU assembler (GNU Binutils for Ubuntu) 2.22

# Fedora: GNU assembler version 2.23.2

- version_re = re.compile(r"^GNU [^ ]+ .* (\d+)\.(\d+)\.*?$", re.M)

+ version_re = re.compile(r"^GNU [^ ]+ .* (\d+).(\d+).*?$", re.M)

elif tool == "linker":

compiler = compiler + " -Xlinker --version"

# Using BFD linker

@@ -39,7 +39,7 @@

# Unmodified: GNU gold (GNU Binutils 2.24) 1.11

# Ubuntu: GNU gold (GNU Binutils for Ubuntu 2.22) 1.11

# Fedora: GNU gold (version 2.23.2) 1.11

- version_re = re.compile(r"^GNU [^ ]+ .* (\d+)\.(\d+)\.*?$", re.M)

+ version_re = re.compile(r"^GNU [^ ]+ .* (\d+).(\d+).*?$", re.M)

else:

raise Exception("Unknown tool %s" % tool)

« no previous file with comments | « no previous file | no next file » | no next file with comments »