Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 2083113002: Disable Panels on OSes other than ChromeOS, in preparation to removing the code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: leave flags in place Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index 7d2c9cec5a78d650b69545e879eab81a9327f98c..3ae9d5c8287c2751cc54f5ae65038b1e88bd9066 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -131,11 +131,16 @@ bool PanelManager::ShouldUsePanels(const std::string& extension_id) {
}
#endif // USE_X11 && !OS_CHROMEOS
- // Without --enable-panels, only support Hangouts.
+// Panels are an Eraser target. See http://crbug.com/571511 for details.
+// TODO(dimich): remove the rest of Panels code (except ChromeOS) once
+// erasure is stable.
+#if defined(OS_CHROMEOS)
+ // Without --enable-panels, only support Hangouts on ChromeOS.
stevenjb 2016/06/22 17:08:33 This comment is a bit misleading - Chrome OS does
Dmitry Titov 2016/06/22 17:53:58 It is in fact correct, although I agree not very c
for (const char* id : extension_misc::kHangoutsExtensionIds) {
if (extension_id == id)
return true;
}
+#endif // OS_CHROMEOS
return false;
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698