Disable Panels on OSes other than ChromeOS, in preparation to removing the code.

chrome/browser/ui/panels/panel_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_manager.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 113 matching lines @@
       wm_type != ui::WM_ICE_WM &&
       wm_type != ui::WM_KWIN &&
       wm_type != ui::WM_METACITY &&
       wm_type != ui::WM_MUFFIN &&
       wm_type != ui::WM_MUTTER &&
       wm_type != ui::WM_XFWM4) {
     return false;
   }
 #endif  // USE_X11 && !OS_CHROMEOS
 
-  // Without --enable-panels, only support Hangouts.
+// Panels are an Eraser target. See http://crbug.com/571511 for details.
+// TODO(dimich): remove the rest of Panels code (except ChromeOS) once
+// erasure is stable.
+#if defined(OS_CHROMEOS)
+  // Without --enable-panels, only support Hangouts on ChromeOS.

[stevenjb, 2016/06/22 17:08:33]

This comment is a bit misleading - Chrome OS does not use this code at all.
Maybe we should refer to this feature as "Non Chrome OS Desktop panels" or
something equally awkward? :)

[Dmitry Titov, 2016/06/22 17:53:58]

It is in fact correct, although I agree not very clear. ChromeOS path in
chrome.windows.create is still using static PanelManager::ShouldUsePanels() to
activate. The effect of the change is that this hack will continue to work on
ChromeOS but not on other desktop OSes. Once the disable is stable and Hangouts
team have time to react, I'm planning to clean the code up leaving only ChromeOS
parts, and removing chrome.windows.create hack as soon as we can.

   for (const char* id : extension_misc::kHangoutsExtensionIds) {
     if (extension_id == id)
       return true;
   }
+#endif  // OS_CHROMEOS
 
   return false;
 }
 
 // static
 bool PanelManager::IsPanelStackingEnabled() {
   // Stacked panel mode is not supported in linux-aura.
 #if defined(OS_LINUX)
   return false;
 #else
@@ skipping 420 matching lines @@
 void PanelManager::SetMouseWatcher(PanelMouseWatcher* watcher) {
   panel_mouse_watcher_.reset(watcher);
 }
 
 void PanelManager::OnPanelAnimationEnded(Panel* panel) {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED,
       content::Source<Panel>(panel),
       content::NotificationService::NoDetails());
 }