Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py - Issue 20830003: Get rid of the distinction between modifiers and expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 20830003: Get rid of the distinction between modifiers and expectations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: clean up a couple things Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index 6ace3ebe0c56fdf57110b1951501281c139f7fe4..b5ae2dd78becf879ea9991536fd380c3a3dbbd63 100644

--- a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -147,9 +147,6 @@ def summarize_results(port_obj, expectations, initial_results, retry_results, en

for expecation_string, expectation_enum in test_expectations.TestExpectations.EXPECTATIONS.iteritems():

keywords[expectation_enum] = expecation_string.upper()

- for modifier_string, modifier_enum in test_expectations.TestExpectations.MODIFIERS.iteritems():

- keywords[modifier_enum] = modifier_string.upper()

num_failures_by_type = {}

for expectation in initial_results.tests_by_expectation:

num_failures_by_type[keywords[expectation]] = len(initial_results.tests_by_expectation[expectation] & tbt[test_expectations.NOW])