Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 20830003: Get rid of the distinction between modifiers and expectations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: clean up a couple things Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 results['skipped'] = len(tbt[test_expectations.NOW] & tbe[test_expectations. SKIP]) 140 results['skipped'] = len(tbt[test_expectations.NOW] & tbe[test_expectations. SKIP])
141 141
142 num_passes = 0 142 num_passes = 0
143 num_flaky = 0 143 num_flaky = 0
144 num_missing = 0 144 num_missing = 0
145 num_regressions = 0 145 num_regressions = 0
146 keywords = {} 146 keywords = {}
147 for expecation_string, expectation_enum in test_expectations.TestExpectation s.EXPECTATIONS.iteritems(): 147 for expecation_string, expectation_enum in test_expectations.TestExpectation s.EXPECTATIONS.iteritems():
148 keywords[expectation_enum] = expecation_string.upper() 148 keywords[expectation_enum] = expecation_string.upper()
149 149
150 for modifier_string, modifier_enum in test_expectations.TestExpectations.MOD IFIERS.iteritems():
151 keywords[modifier_enum] = modifier_string.upper()
152
153 num_failures_by_type = {} 150 num_failures_by_type = {}
154 for expectation in initial_results.tests_by_expectation: 151 for expectation in initial_results.tests_by_expectation:
155 num_failures_by_type[keywords[expectation]] = len(initial_results.tests_ by_expectation[expectation] & tbt[test_expectations.NOW]) 152 num_failures_by_type[keywords[expectation]] = len(initial_results.tests_ by_expectation[expectation] & tbt[test_expectations.NOW])
156 # The number of failures by type. 153 # The number of failures by type.
157 results['num_failures_by_type'] = num_failures_by_type 154 results['num_failures_by_type'] = num_failures_by_type
158 155
159 tests = {} 156 tests = {}
160 157
161 for test_name, result in initial_results.results_by_name.iteritems(): 158 for test_name, result in initial_results.results_by_name.iteritems():
162 # Note that if a test crashed in the original run, we ignore 159 # Note that if a test crashed in the original run, we ignore
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 except Exception, e: 273 except Exception, e:
277 _log.warn("Failed to determine svn revision for checkout (cwd: %s, webki t_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj ._filesystem.getcwd(), port_obj.path_from_webkit_base(), e)) 274 _log.warn("Failed to determine svn revision for checkout (cwd: %s, webki t_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj ._filesystem.getcwd(), port_obj.path_from_webkit_base(), e))
278 # Handle cases where we're running outside of version control. 275 # Handle cases where we're running outside of version control.
279 import traceback 276 import traceback
280 _log.debug('Failed to learn head svn revision:') 277 _log.debug('Failed to learn head svn revision:')
281 _log.debug(traceback.format_exc()) 278 _log.debug(traceback.format_exc())
282 results['chromium_revision'] = "" 279 results['chromium_revision'] = ""
283 results['blink_revision'] = "" 280 results['blink_revision'] = ""
284 281
285 return results 282 return results
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698