Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py

Issue 20830003: Get rid of the distinction between modifiers and expectations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: clean up a couple things Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py b/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
index 49b36e4ecff35aaf3a1c72f836ce29fa755b62a8..2527c8f1eae4a2e4f297dc3760b079d1cf958387 100644
--- a/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
@@ -157,7 +157,7 @@ class TestConfigurationConverter(object):
configurations = self._specifier_to_configuration_set.get(expanded_specifier)
if not configurations:
if error_list is not None:
- error_list.append("Unrecognized modifier '" + expanded_specifier + "'")
+ error_list.append("Unrecognized specifier '" + expanded_specifier + "'")
return set()
category = self._specifier_sorter.category_for_specifier(expanded_specifier)
matching_sets.setdefault(category, set()).update(configurations)
@@ -233,7 +233,7 @@ class TestConfigurationConverter(object):
def to_specifiers_list(self, test_configuration_set):
"""Convert a set of TestConfiguration instances into one or more list of specifiers."""
- # Easy out: if the set is all configurations, the modifier is empty.
+ # Easy out: if the set is all configurations, the specifier is empty.
if len(test_configuration_set) == len(self._all_test_configurations):
return [[]]

Powered by Google App Engine
This is Rietveld 408576698