Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py - Issue 20830003: Get rid of the distinction between modifiers and expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

Issue 20830003: Get rid of the distinction between modifiers and expectations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: clean up a couple things Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

index 03df8b6a904fb530c8cba75c1f062dc178a05661..70998e195b28b338ce8ece36eae156d378fb69d7 100644

--- a/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

+++ b/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

@@ -64,7 +64,6 @@ def lint(host, options, logging_stream):

for port_to_lint in ports_to_lint:

expectations_dict = port_to_lint.expectations_dict()

- # FIXME: This won't work if multiple ports share a TestExpectations file but support different modifiers in the file.

for expectations_file in expectations_dict.keys():

if expectations_file in files_linted:

continue