Issue 2082723002: [Material][Mac] Set Incognito Omnibox Dropdown Icons to White

Issue 2082723002: [Material][Mac] Set Incognito Omnibox Dropdown Icons to White (Closed)

Created:
4 years, 6 months ago by spqchan

Modified:
4 years, 5 months ago

Reviewers:
shrike, rohitrao (ping after 24h)

CC:
chromium-reviews, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Material][Mac] Set Incognito Omnibox Dropdown Icons to White BUG=618763 Committed: https://crrev.com/a8403516d197bb546c068d3202f41844a004892e Cr-Commit-Position: refs/heads/master@{#402634}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 13 (4 generated)

shrike

Thank you for looking into this and fixing my mistake. lgtm

4 years, 6 months ago (2016-06-21 23:35:11 UTC) #3

spqchan

On 2016/06/22 17:39:56, spqchan wrote: > No problem > > +rohitrao for OWNERS ping

4 years, 6 months ago (2016-06-23 16:30:28 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2082723002/1

4 years, 5 months ago (2016-06-29 00:10:07 UTC) #10

commit-bot: I haz the power

4 years, 5 months ago (2016-06-29 01:48:05 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a8403516d197bb546c068d3202f41844a004892e
Cr-Commit-Position: refs/heads/master@{#402634}