chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm - Issue 2082723002: [Material][Mac] Set Incognito Omnibox Dropdown Icons to White

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

Issue 2082723002: [Material][Mac] Set Incognito Omnibox Dropdown Icons to White (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

index 19889e9a3e59135a2964b300f264ef053283a17e..8e378ca2352489352bc63a6cdfa3f1137644b1b5 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

@@ -43,12 +43,11 @@ const NSInteger kMiddleButtonNumber = 2;

[[OmniboxPopupCellData alloc]

initWithMatch:match

contentsOffset:contentsOffset

- image:popupView.ImageForMatch(match, NO)

+ image:popupView.ImageForMatch(match)

answerImage:(match.answer ? answerImage : nil)

forDarkTheme:isDarkTheme]);

- if (isDarkTheme) {

- [cellData setIncognitoImage:popupView.ImageForMatch(match, YES)];

- }

+ if (isDarkTheme)

+ [cellData setIncognitoImage:popupView.ImageForMatch(match)];

[array addObject:cellData];

if (match.type == AutocompleteMatchType::SEARCH_SUGGEST_TAIL) {

max_match_contents_width =

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h » ('j') | no next file with comments »