Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 208263016: Revert "Enable DMP for system Chromium WebView on Android" (Closed)

Created:
6 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Enable DMP for system Chromium WebView on Android" This reverts commit a2f57e2cbfffa257ef542aa44807ee5d616cd15d. (http://crrev.com/18314006) Reason for the revert: it is not being actively used anymore, since having tcmalloc in libwebviewchromium.so doens't help with allocations from other libraries like system skia. Also, some work on the android_use_tcmalloc is ongoing and this dead code is adding unnecessary maintaining effort. BUG=345554 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M base/allocator/allocator.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/tcmalloc/chromium/src/base/linux_syscall_support.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Primiano Tucci (use gerrit)
6 years, 9 months ago (2014-03-24 14:19:24 UTC) #1
mnaganov (inactive)
lgtm
6 years, 9 months ago (2014-03-24 16:06:22 UTC) #2
Dai Mikurube (NOT FULLTIME)
lgtm
6 years, 9 months ago (2014-03-24 16:10:39 UTC) #3
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-24 16:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/208263016/1
6 years, 9 months ago (2014-03-24 16:37:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:18:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57031
6 years, 9 months ago (2014-03-24 17:18:26 UTC) #7
Primiano Tucci (use gerrit)
+willchan for OWNER stamp.
6 years, 9 months ago (2014-03-24 18:22:45 UTC) #8
willchan no longer on Chromium
lgtm
6 years, 9 months ago (2014-03-24 19:15:49 UTC) #9
willchan no longer on Chromium
The CQ bit was checked by willchan@chromium.org
6 years, 9 months ago (2014-03-24 19:15:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/208263016/1
6 years, 9 months ago (2014-03-24 19:17:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 22:09:39 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=287039
6 years, 9 months ago (2014-03-24 22:09:40 UTC) #13
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-25 07:02:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/208263016/1
6 years, 9 months ago (2014-03-25 07:02:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/208263016/1
6 years, 9 months ago (2014-03-25 12:51:14 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:41:29 UTC) #17
Message was sent while issue was closed.
Change committed as 259209

Powered by Google App Engine
This is Rietveld 408576698