third_party/tcmalloc/chromium/src/heap-profiler.cc - Issue 208263016: Revert "Enable DMP for system Chromium WebView on Android"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/heap-profiler.cc

Issue 208263016: Revert "Enable DMP for system Chromium WebView on Android" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/base/linux_syscall_support.h ('k') | third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/heap-profiler.cc

diff --git a/third_party/tcmalloc/chromium/src/heap-profiler.cc b/third_party/tcmalloc/chromium/src/heap-profiler.cc

index d27e0b304aa2d0b7da8c13246beee173dec91563..da4ed49bea7cc701bd4857d60710395ecac64861 100644

--- a/third_party/tcmalloc/chromium/src/heap-profiler.cc

+++ b/third_party/tcmalloc/chromium/src/heap-profiler.cc

@@ -671,7 +671,7 @@ static void HeapProfilerInit() {

return;

}

// We do a uid check so we don't write out files in a setuid executable.

-#if !defined(__ANDROID__) && defined(HAVE_GETEUID)

+#ifdef HAVE_GETEUID

if (getuid() != geteuid()) {

RAW_LOG(WARNING, ("HeapProfiler: ignoring " HEAPPROFILE " because "

"program seems to be setuid\n"));