Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html

Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Merged https://codereview.chromium.org/208263012/ to this patch. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html
diff --git a/LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html b/LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..b5688d7aad344313d1f1cbf1a1a18f04cc5802d8
--- /dev/null
+++ b/LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function runTest() {
+ document.getElementById("column1").width = "90";
+ var firstRow = document.getElementById("firstRow");
+ firstRow.removeChild(firstRow.firstElementChild);
+ document.getElementById("row").offsetWidth;
+ }
+ </script>
+ <style>
+ .column2 {
+ width: 10px;
+ }
+ </style>
+ </head>
+ <body onload="runTest()">
+ <table>
+ <colgroup>
+ <col id="column1" class="column1">
+ <col class="column2">
+ </colgroup>
+ <tbody>
+ <tr id="firstRow">
+ <td colspan="4"></td>
+ </tr>
+ <tr id="row">
+ <td colspan="4"></td>
+ </tr>
+ </tbody>
+ </table>
+ <p>This test PASSED if it doesn't cause a crash, especially when run with Guard Malloc or MallocScribble enabled.</p>
+ </body>
+</html>
+

Powered by Google App Engine
This is Rietveld 408576698