LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html - Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash.html

Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Merged https://codereview.chromium.org/208263012/ to this patch. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/table/resize-table-width-using-multiple-col-span-expected.txt ('k') | LayoutTests/fast/table/update-col-width-and-remove-table-cell-crash-expected.txt » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7

	8 function runTest() {

	9 document.getElementById("column1").width = "90";

	10 var firstRow = document.getElementById("firstRow");

	11 firstRow.removeChild(firstRow.firstElementChild);

	12 document.getElementById("row").offsetWidth;

	13 }

	14 </script>

	15 <style>

	16 .column2 {

	17 width: 10px;

	18 }

	19 </style>

	20 </head>

	21 <body onload="runTest()">

	22 <table>

	23 <colgroup>

	24 <col id="column1" class="column1">

	25 <col class="column2">

	26 </colgroup>

	27 <tbody>

	28 <tr id="firstRow">

	29 <td colspan="4"></td>

	30 </tr>

	31 <tr id="row">

	32 <td colspan="4"></td>

	33 </tr>

	34 </tbody>

	35 </table>

	36 <p>This test PASSED if it doesn't cause a crash, especially when run wit h Guard Malloc or MallocScribble enabled.</p>

	37 </body>

	38 </html>

	39

OLD	NEW