Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2082573006: [iOS/GN] Replace the last to gyp-mac-tool commands with standalone scripts. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Replace the last to gyp-mac-tool commands with standalone scripts. This adds write_framework_hmap.py and write_framework_modulemap.py under //build/config/ios/. BUG=616813 R=sdefresne@chromium.org Committed: https://crrev.com/fc86361978c030bac431d9745c2de6a8eed6d014 Cr-Commit-Position: refs/heads/master@{#401228}

Patch Set 1 #

Patch Set 2 : return 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -7 lines) Patch
M build/config/ios/rules.gni View 3 chunks +3 lines, -7 lines 0 comments Download
A build/config/ios/write_framework_hmap.py View 1 1 chunk +97 lines, -0 lines 0 comments Download
A build/config/ios/write_framework_modulemap.py View 1 chunk +26 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Robert Sesek
Please cq if lg.
4 years, 6 months ago (2016-06-21 22:11:55 UTC) #1
sdefresne
lgtm
4 years, 6 months ago (2016-06-22 07:17:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082573006/20001
4 years, 6 months ago (2016-06-22 07:17:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 08:13:43 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 08:15:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc86361978c030bac431d9745c2de6a8eed6d014
Cr-Commit-Position: refs/heads/master@{#401228}

Powered by Google App Engine
This is Rietveld 408576698