Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 2081933004: [Mac/iOS/GN] Remove setup_toolchain.py since gyp-mac-tool is not needed anymore. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-ios-gyp-tool
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Remove setup_toolchain.py since gyp-mac-tool is not needed anymore. BUG=616813 R=dpranke@chromium.org Committed: https://crrev.com/d6ab13319cf869060624f7ade7f4f952e7f95ea7 Cr-Commit-Position: refs/heads/master@{#401300}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D build/toolchain/mac/setup_toolchain.py View 1 chunk +0 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Robert Sesek
4 years, 6 months ago (2016-06-22 15:12:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081933004/20001
4 years, 6 months ago (2016-06-22 15:12:55 UTC) #3
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-22 15:37:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 16:18:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081933004/20001
4 years, 6 months ago (2016-06-22 16:23:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 16:28:27 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 16:30:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6ab13319cf869060624f7ade7f4f952e7f95ea7
Cr-Commit-Position: refs/heads/master@{#401300}

Powered by Google App Engine
This is Rietveld 408576698