third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2082503003: ASSERT -> DCHECK conversions in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index c58696bac7e974335f45eabb99581b0597a04278..43759f16e595ea16905a333fb05a84f5c2e90533 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -892,7 +892,7 @@ void ReplaceSelectionCommand::mergeEndIfNeeded(EditingState* editingState)

// Bail to avoid infinite recursion.

if (m_movingParagraph) {

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return;

}

@@ -1641,7 +1641,7 @@ Node* ReplaceSelectionCommand::insertAsListItems(HTMLElement* listElement, Eleme

insertedNodes.respondToNodeInsertion(*listItem);

lastNode = listItem;

} else {

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

if (isStart || isMiddle) {