Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2082473002: Move third_party/libjingle/overrides to third_party/webrtc_overrides (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move third_party/libjingle/overrides to third_party/webrtc_overrides Remove non-existing include path references to the old libjingle source dir as well. Don't update any targets to reduce complexity in landing the switch in https://codereview.chromium.org/2022833002 first. After that's done the target should be moved into third_party/webrtc_overrides. BUG=webrtc:4256 Committed: https://crrev.com/d117efcea96c60d461e351a1c7a5bc0046d9b945 Cr-Commit-Position: refs/heads/master@{#400755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -135 lines) Patch
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/libjingle/libjingle_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 4 chunks +1 line, -5 lines 0 comments Download
D third_party/libjingle/overrides/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/libjingle/overrides/field_trial.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/libjingle/overrides/init_webrtc.h View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +0 lines, -79 lines 0 comments Download
A + third_party/webrtc_overrides/field_trial.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/webrtc_overrides/init_webrtc.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/webrtc_overrides/init_webrtc.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082473002/1
4 years, 6 months ago (2016-06-20 06:42:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/129602)
4 years, 6 months ago (2016-06-20 06:54:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082473002/20001
4 years, 6 months ago (2016-06-20 07:03:12 UTC) #6
kjellander_chromium
grunell: main review. sergeyu: src/jingle jochen: src/content
4 years, 6 months ago (2016-06-20 07:38:17 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 07:51:14 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 11:31:59 UTC) #15
Henrik Grunell
lgtm I can't see any issues, hopefully the bots don't either.
4 years, 6 months ago (2016-06-20 14:48:29 UTC) #16
Sergey Ulanov
lgtm
4 years, 6 months ago (2016-06-20 16:57:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082473002/20001
4 years, 6 months ago (2016-06-20 19:58:53 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-20 20:04:24 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 20:07:07 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d117efcea96c60d461e351a1c7a5bc0046d9b945
Cr-Commit-Position: refs/heads/master@{#400755}

Powered by Google App Engine
This is Rietveld 408576698