Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2022833002: Migrate libjingle to WebRTC build targets. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, perkj_chrome
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. Committed: https://crrev.com/d0e9a0766b7c360fb4524e226b9f6bbdf5e68333 Cr-Commit-Position: refs/heads/master@{#408931}

Patch Set 1 #

Patch Set 2 : Fixed configs #

Total comments: 4

Patch Set 3 : Moved out xmllite and xmpp dependencies closer to its dependents #

Patch Set 4 : Adding DEPS roll #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Patch Set 7 : Applied https://codereview.chromium.org/2082473002 #

Patch Set 8 : Added exported dependencies for libjingle target to address missing defines #

Patch Set 9 : Rebased and added NaCl GYP dependencies #

Patch Set 10 : Add nacl_io_untrusted to libjingle_nacl.gyp dependencies #

Patch Set 11 : Fixed typo in libjingle_nacl.gyp #

Patch Set 12 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -674 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -0 lines 0 comments Download
M jingle/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M jingle/jingle.gyp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +12 lines, -2 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/signaling/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +36 lines, -306 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +11 lines, -262 lines 0 comments Download
M third_party/libjingle/libjingle_common.gypi View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -102 lines 0 comments Download
M third_party/webrtc_overrides/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 83 (44 generated)
kjellander_chromium
4 years, 6 months ago (2016-05-31 12:58:49 UTC) #4
tommi (sloooow) - chröme
https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/BUILD.gn#newcode53 third_party/libjingle/BUILD.gn:53: "//third_party/webrtc/libjingle/xmllite", out of curiosity - do you know what ...
4 years, 6 months ago (2016-05-31 13:36:09 UTC) #5
kjellander_chromium
+sergeyu for src/jingle and src/remoting. jochen: please have a look at src/content. https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn ...
4 years, 6 months ago (2016-05-31 21:20:19 UTC) #7
Sergey Ulanov
lgtm
4 years, 6 months ago (2016-06-01 07:35:00 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-01 07:57:12 UTC) #10
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-06-01 09:09:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022833002/40001
4 years, 6 months ago (2016-06-01 09:51:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/74524) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-01 09:54:12 UTC) #15
kjellander_chromium
On 2016/06/01 09:54:12, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-01 10:57:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022833002/60001
4 years, 6 months ago (2016-06-01 10:57:51 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/170297)
4 years, 6 months ago (2016-06-01 11:08:40 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/80001
4 years, 6 months ago (2016-06-09 12:19:27 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/213762) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 6 months ago (2016-06-09 12:23:28 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/100001
4 years, 6 months ago (2016-06-19 06:03:09 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/187965)
4 years, 6 months ago (2016-06-19 06:07:06 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/120001
4 years, 6 months ago (2016-06-20 07:39:30 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/188068)
4 years, 6 months ago (2016-06-20 07:43:22 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/140001
4 years, 6 months ago (2016-06-20 08:35:16 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/188081)
4 years, 6 months ago (2016-06-20 08:39:23 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/180001
4 years, 6 months ago (2016-06-22 04:50:22 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189541)
4 years, 6 months ago (2016-06-22 04:59:23 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/180001
4 years, 6 months ago (2016-06-22 07:57:39 UTC) #48
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189616)
4 years, 6 months ago (2016-06-22 08:05:36 UTC) #50
kjellander_chromium
So, after landing a collection of blocking CLs https://codereview.chromium.org/2076883004 (NaCl) https://codereview.webrtc.org/2074423002/ (sign-compare warnings) https://codereview.webrtc.org/2080563002/ (java.gypi ...
4 years, 6 months ago (2016-06-22 09:16:31 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/220001
4 years, 6 months ago (2016-06-22 09:16:57 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189650)
4 years, 6 months ago (2016-06-22 09:26:17 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
4 years, 6 months ago (2016-06-22 09:30:43 UTC) #59
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189666)
4 years, 6 months ago (2016-06-22 11:25:46 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
4 years, 6 months ago (2016-06-22 12:18:24 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/189696)
4 years, 6 months ago (2016-06-22 14:06:58 UTC) #65
kjellander_chromium
On 2016/06/22 14:06:58, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-22 14:55:51 UTC) #66
kjellander_chromium
On 2016/06/22 14:55:51, kjellander_chromium wrote: > On 2016/06/22 14:06:58, commit-bot: I haz the power wrote: ...
4 years, 6 months ago (2016-06-22 17:10:41 UTC) #67
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
4 years, 6 months ago (2016-06-23 13:37:01 UTC) #69
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/190475)
4 years, 6 months ago (2016-06-23 15:28:07 UTC) #71
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2022833002/240001
4 years, 5 months ago (2016-06-28 12:46:48 UTC) #73
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/192894)
4 years, 5 months ago (2016-06-28 14:39:48 UTC) #75
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2022833002/280001
4 years, 4 months ago (2016-08-01 07:12:02 UTC) #79
commit-bot: I haz the power
Committed patchset #12 (id:280001)
4 years, 4 months ago (2016-08-01 08:51:48 UTC) #81
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 08:54:20 UTC) #83
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/d0e9a0766b7c360fb4524e226b9f6bbdf5e68333
Cr-Commit-Position: refs/heads/master@{#408931}

Powered by Google App Engine
This is Rietveld 408576698