|
|
Created:
4 years, 6 months ago by kjellander_chromium Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, perkj_chrome Base URL:
http://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMigrate libjingle to WebRTC build targets.
This is a large improvement from the previous duplicated lists of
source files in WebRTC. This moves over to using the GYP/GN targets
in third_party/webrtc instead, which has become possible after landing
https://codereview.webrtc.org/1924663003/ and
https://codereview.webrtc.org/2037983002/.
BUG=webrtc:4256
TESTED=Local builds passing for Linux and Android.
Committed: https://crrev.com/d0e9a0766b7c360fb4524e226b9f6bbdf5e68333
Cr-Commit-Position: refs/heads/master@{#408931}
Patch Set 1 #Patch Set 2 : Fixed configs #
Total comments: 4
Patch Set 3 : Moved out xmllite and xmpp dependencies closer to its dependents #Patch Set 4 : Adding DEPS roll #Patch Set 5 : Rebased #Patch Set 6 : Rebased #Patch Set 7 : Applied https://codereview.chromium.org/2082473002 #Patch Set 8 : Added exported dependencies for libjingle target to address missing defines #Patch Set 9 : Rebased and added NaCl GYP dependencies #Patch Set 10 : Add nacl_io_untrusted to libjingle_nacl.gyp dependencies #Patch Set 11 : Fixed typo in libjingle_nacl.gyp #Patch Set 12 : Rebased #
Messages
Total messages: 83 (44 generated)
Description was changed from ========== Migrate from libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (should be done in this same CL). BUG=webrtc:4256 ========== to ========== Migrate from libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (should be done in this same CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ==========
kjellander@chromium.org changed reviewers: + jochen@chromium.org, tommi@chromium.org
Description was changed from ========== Migrate from libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (should be done in this same CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ========== to ========== Migrate from libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ==========
https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/B... File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/B... third_party/libjingle/BUILD.gn:53: "//third_party/webrtc/libjingle/xmllite", out of curiosity - do you know what projects depend on xmllite and xmpp via the libjingle target? I wonder if it would make sense to move those dependency out of this target. https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/l... File third_party/libjingle/libjingle.gyp (right): https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/l... third_party/libjingle/libjingle.gyp:84: '<(DEPTH)/third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp', same here
kjellander@chromium.org changed reviewers: + sergeyu@chromium.org
+sergeyu for src/jingle and src/remoting. jochen: please have a look at src/content. https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/B... File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/B... third_party/libjingle/BUILD.gn:53: "//third_party/webrtc/libjingle/xmllite", On 2016/05/31 13:36:09, tommi-chrömium wrote: > out of curiosity - do you know what projects depend on xmllite and xmpp via the > libjingle target? > I wonder if it would make sense to move those dependency out of this target. I believe it's only src/jingle and src/remoting. I moved the dependencies out there and it seems to build fine. We won't know for sure until we've landed the WebRTC CL and tried a roll combined with this CL. https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/l... File third_party/libjingle/libjingle.gyp (right): https://codereview.chromium.org/2022833002/diff/20001/third_party/libjingle/l... third_party/libjingle/libjingle.gyp:84: '<(DEPTH)/third_party/webrtc/libjingle/xmpp/xmpp.gyp:rtc_xmpp', On 2016/05/31 13:36:09, tommi-chrömium wrote: > same here Done (see previous comment).
Description was changed from ========== Migrate from libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ========== to ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ==========
lgtm
lgtm
lgtm
The CQ bit was checked by guidou@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022833002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. ========== to ========== Roll WebRTC 12982:12986 + migrate libjingle to WebRTC build targets. Roll changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c0150... This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng ==========
On 2016/06/01 09:54:12, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) > ios-device-gn on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) > mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) guidiou misunderstood me and sent this CL to the CQ before adding the DEPS roll information. I did that now so it hopefully can land now *crossing fingers*
The CQ bit was checked by kjellander@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, jochen@chromium.org, tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2022833002/#ps60001 (title: "Adding DEPS roll")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022833002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Roll WebRTC 12982:12986 + migrate libjingle to WebRTC build targets. Roll changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c0150... This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. This CL depends on https://codereview.webrtc.org/1979933002/ being landed and rolled as well (I'll patch this CL into the roll CL). BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android with this CL applied and https://codereview.webrtc.org/1979933002/ patched into src/third_party/webrtc. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng ========== to ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ==========
Description was changed from ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ========== to ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ==========
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #9 (id:160001) has been deleted
Patchset #10 (id:200001) has been deleted
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
So, after landing a collection of blocking CLs https://codereview.chromium.org/2076883004 (NaCl) https://codereview.webrtc.org/2074423002/ (sign-compare warnings) https://codereview.webrtc.org/2080563002/ (java.gypi inclusion error) https://codereview.chromium.org/2082473002/ (third_party/libjingle/overrides) and waiting for the native_client toolchain to be updated and rolled into Chromium DEPS, I think I'm now finally able to commit this.
The CQ bit was checked by kjellander@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, jochen@chromium.org, tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2022833002/#ps220001 (title: "Add nacl_io_untrusted to libjingle_nacl.gyp dependencies")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/220001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, jochen@chromium.org, tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2022833002/#ps240001 (title: "Fixed typo in libjingle_nacl.gyp")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/06/22 14:06:58, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Does anyone have any idea why the linux_chromium_chromeos_ozone_rel_ng trybot fails over and over? It seems to hang on linking: [8417/8612] RULE interactive_ui_tests_run: isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate command timed out: 2400 seconds without output, attempting to kill process killed by signal 9 program finished with exit code -1 elapsedTime=3255.023309
On 2016/06/22 14:55:51, kjellander_chromium wrote: > On 2016/06/22 14:06:58, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux > (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > > Does anyone have any idea why the linux_chromium_chromeos_ozone_rel_ng trybot > fails over and over? > It seems to hang on linking: > [8417/8612] RULE interactive_ui_tests_run: > isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate > command timed out: 2400 seconds without output, attempting to kill > process killed by signal 9 > program finished with exit code -1 > elapsedTime=3255.023309 I filed https://bugs.chromium.org/p/chromium/issues/detail?id=622373 hoping for assistance.
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022833002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #12 (id:260001) has been deleted
The CQ bit was checked by kjellander@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, jochen@chromium.org, tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2022833002/#ps280001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ========== to ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ==========
Message was sent while issue was closed.
Committed patchset #12 (id:280001)
Message was sent while issue was closed.
Description was changed from ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. ========== to ========== Migrate libjingle to WebRTC build targets. This is a large improvement from the previous duplicated lists of source files in WebRTC. This moves over to using the GYP/GN targets in third_party/webrtc instead, which has become possible after landing https://codereview.webrtc.org/1924663003/ and https://codereview.webrtc.org/2037983002/. BUG=webrtc:4256 TESTED=Local builds passing for Linux and Android. Committed: https://crrev.com/d0e9a0766b7c360fb4524e226b9f6bbdf5e68333 Cr-Commit-Position: refs/heads/master@{#408931} ==========
Message was sent while issue was closed.
Patchset 12 (id:??) landed as https://crrev.com/d0e9a0766b7c360fb4524e226b9f6bbdf5e68333 Cr-Commit-Position: refs/heads/master@{#408931} |