Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 208243016: Fix collected properties in window-property-collector.js (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix collected properties in window-property-collector.js This change made bug 347020 obvious in the sense that without CL 208333018, LayoutTests would crash. A side effect of this change is that mac-specific results can be removed. BUG=347020 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170171

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove mac-specific results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -364 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 chunks +41 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +44 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +44 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 3 chunks +139 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 chunks +142 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 chunks +142 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-property-collector.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mlamouri (slow - plz ping)
I will have to update the mac expected results but otherwise, I believe it is ...
6 years, 9 months ago (2014-03-26 16:02:18 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-26 16:23:58 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-27 11:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/208243016/60001
6 years, 9 months ago (2014-03-27 11:15:09 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 12:25:44 UTC) #5
Message was sent while issue was closed.
Change committed as 170171

Powered by Google App Engine
This is Rietveld 408576698