Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 208243016: Fix collected properties in window-property-collector.js (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove mac-specific results Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/Window/resources/window-property-collector.js
diff --git a/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/LayoutTests/fast/dom/Window/resources/window-property-collector.js
index 67219975c643d4398471458766d9fce3a42ac152..0578c8d46adccf4811b7105a05e527df2932789e 100644
--- a/LayoutTests/fast/dom/Window/resources/window-property-collector.js
+++ b/LayoutTests/fast/dom/Window/resources/window-property-collector.js
@@ -85,16 +85,16 @@ function collectPropertiesHelper(object, path)
// As for 'localStorage', local storage is not reliably cleared between tests.
if (property == 'localStorage')
continue;
- if (!object[property])
- continue;
path.push(property);
var type = typeof(object[property]);
if (type == "object") {
- // Skip some traversing through types that will end up in cycles...
- if (!object[property].Window
+ if (object[property] === null) {
+ emitExpectedResult(path, "null");
+ } else if (!object[property].Window
&& !(object[property] instanceof Node)
&& !(object[property] instanceof MimeTypeArray)
&& !(object[property] instanceof PluginArray)) {
+ // Skip some traversing through types that will end up in cycles...
collectPropertiesHelper(object[property], path);
}
} else if (type == "string") {

Powered by Google App Engine
This is Rietveld 408576698