Issue 208243012: Mac: Do not call PopupMenuClient::popupDidHide in ExternalPopupMenu:show.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208243012: Mac: Do not call PopupMenuClient::popupDidHide in ExternalPopupMenu:show. (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
keishi

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Mac: Do not call PopupMenuClient::popupDidHide in ExternalPopupMenu:show. Replace hide() in ExternalPopupMenu:show() with m_webExternalPopupMenu->close(). It means we remove PopupMenuClient::popupDidHide() call. We should not call it because the client changes its state to "no popup" state by the popupDidHide call, and it won't call PopupMenu::hide() even if it's necessary. BUG=30550, 145658 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169901

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	LayoutTests/fast/forms/select/popup-closes-on-blur-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/platform/mac/fast/forms/select/select-disabled-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/ExternalPopupMenu.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/208243012/1

6 years, 9 months ago (2014-03-25 01:42:05 UTC) #4

Message was sent while issue was closed.

Change committed as 169901

Expand Messages | Collapse Messages