Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: Source/web/ExternalPopupMenu.cpp

Issue 208243012: Mac: Do not call PopupMenuClient::popupDidHide in ExternalPopupMenu:show. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/select/select-disabled-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenu.cpp
diff --git a/Source/web/ExternalPopupMenu.cpp b/Source/web/ExternalPopupMenu.cpp
index a1075db6f0f969ffca5151f58335509cdd62bc17..70221f782ef3fb0df075b6613f9738e12db37673 100644
--- a/Source/web/ExternalPopupMenu.cpp
+++ b/Source/web/ExternalPopupMenu.cpp
@@ -64,9 +64,12 @@ ExternalPopupMenu::~ExternalPopupMenu()
void ExternalPopupMenu::show(const FloatQuad& controlPosition, const IntSize&, int index)
{
IntRect rect(controlPosition.enclosingBoundingBox());
- // WebCore reuses the PopupMenu of a page.
+ // WebCore reuses the PopupMenu of an element.
// For simplicity, we do recreate the actual external popup everytime.
- hide();
+ if (m_webExternalPopupMenu) {
+ m_webExternalPopupMenu->close();
+ m_webExternalPopupMenu = 0;
+ }
WebPopupMenuInfo info;
getPopupMenuInfo(&info);
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/select/select-disabled-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698