Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2082383003: Fix black frames on segment boundaries in H/W decoded h.264 video on windows. (Closed)

Created:
4 years, 6 months ago by ananta
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix black frames on segment boundaries in H/W decoded h.264 video on windows. Merging to M52 When we detect a segment boundary we reinitialize the decoder. Currently on Windows that results in tearing down the decoder instance the D3D9/D3D11 device objects, the output picture buffers etc. We don't need to tear down the output picture buffers and the d3d device objects. This fixes the black frame which shows up due to the picture buffers getting destroyed and new ones getting created. In any case if the resolution changes we do request new output buffers anyways. I tested the test case in bug 594266 which was the reason for the config change code in the first place. That still works in D3d9 and D3D11. BUG=616349 Review-Url: https://codereview.chromium.org/2040093002 Cr-Commit-Position: refs/heads/master@{#398226} (cherry picked from commit 5795198277f6c7e1e5871d343c1dbadba1a505d6) Committed: https://chromium.googlesource.com/chromium/src/+/1f9b16ef7e1d1ad069331705a08eaf59cea7897a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 4 chunks +35 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
4 years, 6 months ago (2016-06-22 22:24:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f9b16ef7e1d1ad069331705a08eaf59cea7897a.

Powered by Google App Engine
This is Rietveld 408576698