Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2040093002: Fix black frames on segment boundaries in H/W decoded h.264 video on windows. (Closed)

Created:
4 years, 6 months ago by ananta
Modified:
4 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix black frames on segment boundaries in H/W decoded h.264 video on windows. When we detect a segment boundary we reinitialize the decoder. Currently on Windows that results in tearing down the decoder instance the D3D9/D3D11 device objects, the output picture buffers etc. We don't need to tear down the output picture buffers and the d3d device objects. This fixes the black frame which shows up due to the picture buffers getting destroyed and new ones getting created. In any case if the resolution changes we do request new output buffers anyways. I tested the test case in bug 594266 which was the reason for the config change code in the first place. That still works in D3d9 and D3D11. BUG=616349 Committed: https://crrev.com/5795198277f6c7e1e5871d343c1dbadba1a505d6 Cr-Commit-Position: refs/heads/master@{#398226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 4 chunks +35 lines, -25 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
ananta
4 years, 6 months ago (2016-06-07 00:36:16 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 6 months ago (2016-06-07 01:11:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040093002/1
4 years, 6 months ago (2016-06-07 01:37:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 04:40:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 04:42:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5795198277f6c7e1e5871d343c1dbadba1a505d6
Cr-Commit-Position: refs/heads/master@{#398226}

Powered by Google App Engine
This is Rietveld 408576698