Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2081993002: MIPS: Fix 'MIPS: Followup [turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPr… (Closed)

Created:
4 years, 6 months ago by balazs.kilvady
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'MIPS: Followup [turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan.' Port eff959bb5593668a82dfb5c04c464ddcb8a3315c Original commit message: Float32SubMinusZero and Float64SubMinusZero tests are failing because MIPS does not preserve NaN payload according to Wasm spec. Implemented macro-assembler methods that check for NaN operands, and return the qNaN value with preserved payload and sign bits. TEST=cctest/test-run-wasm/Run_WasmFloat32SubMinusZero, cctest/test-run-wasm/Run_WasmFloat64SubMinusZero BUG= Committed: https://crrev.com/8c4e388e50fb6eb318cffa0d607917fa5034ac2c Cr-Commit-Position: refs/heads/master@{#37151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 6 months ago (2016-06-21 13:15:39 UTC) #2
akos.palfi.imgtec
Lgtm
4 years, 6 months ago (2016-06-21 16:37:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081993002/1
4 years, 6 months ago (2016-06-21 16:39:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 17:04:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:05:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c4e388e50fb6eb318cffa0d607917fa5034ac2c
Cr-Commit-Position: refs/heads/master@{#37151}

Powered by Google App Engine
This is Rietveld 408576698