Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2081963003: Simplify SyncChannel message pumping event (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SyncChannel message pumping event There's no need to use ref-counted or thread-local storage for this. It can be a single leaky MojoEvent instance. BUG=612500 Committed: https://crrev.com/9981a62a54d9d82c3cdbccb830f637a874f117da Cr-Commit-Position: refs/heads/master@{#401342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M ipc/ipc_sync_channel.h View 3 chunks +1 line, -4 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 4 chunks +12 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Rockot(use gerrit already)
I was too slow to cancel the CQ on the last CL. As you suggested ...
4 years, 6 months ago (2016-06-21 22:55:29 UTC) #3
jam
lgtm
4 years, 6 months ago (2016-06-22 16:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081963003/1
4 years, 6 months ago (2016-06-22 16:55:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:08:07 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:12:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9981a62a54d9d82c3cdbccb830f637a874f117da
Cr-Commit-Position: refs/heads/master@{#401342}

Powered by Google App Engine
This is Rietveld 408576698