Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ipc/ipc_sync_channel.h

Issue 2081963003: Simplify SyncChannel message pumping event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_sync_channel.h
diff --git a/ipc/ipc_sync_channel.h b/ipc/ipc_sync_channel.h
index cb759de2c3d9834e65d4d6b19efebb37d699c519..e8c96d209adfca3ad7154d715a64cb3860a0341c 100644
--- a/ipc/ipc_sync_channel.h
+++ b/ipc/ipc_sync_channel.h
@@ -211,8 +211,6 @@ class IPC_EXPORT SyncChannel : public ChannelProxy {
};
private:
- class PumpMessagesEvent;
-
SyncChannel(
Listener* listener,
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
@@ -228,7 +226,7 @@ class IPC_EXPORT SyncChannel : public ChannelProxy {
// latter one also runs a nested message loop in the meantime.
static void WaitForReply(mojo::SyncHandleRegistry* registry,
SyncContext* context,
- const MojoEvent* pump_messages_event);
+ bool pump_messages);
// Runs a nested message loop until a reply arrives, times out, or the process
// shuts down.
@@ -240,7 +238,6 @@ class IPC_EXPORT SyncChannel : public ChannelProxy {
// ChannelProxy overrides:
void OnChannelInit() override;
- scoped_refptr<PumpMessagesEvent> pump_messages_event_;
scoped_refptr<mojo::SyncHandleRegistry> sync_handle_registry_;
// Used to signal events between the IPC and listener threads.
« no previous file with comments | « no previous file | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698