Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2081893002: [Hunspell] Better handling of invalid dictionary (Closed)

Created:
4 years, 6 months ago by groby-ooo-7-16
Modified:
4 years, 6 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, mmoroz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Hunspell] Better handling of invalid dictionary When dictionary data is invalid, this code returns a default (empty) iterator. BUG=618040, 621765 Committed: https://crrev.com/935d1f6af681c09dfc175535924268626f07d5fa Cr-Commit-Position: refs/heads/master@{#401050}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/hunspell/google/bdict_reader.cc View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
groby-ooo-7-16
Rouslan, could you please review?
4 years, 6 months ago (2016-06-21 16:33:44 UTC) #3
please use gerrit instead
lgtm https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google/bdict_reader.cc File third_party/hunspell/google/bdict_reader.cc (right): https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google/bdict_reader.cc#newcode788 third_party/hunspell/google/bdict_reader.cc:788: return ReplacementIterator(bdict_data_, 0, 0); // Item is empty ...
4 years, 6 months ago (2016-06-21 16:35:44 UTC) #4
groby-ooo-7-16
https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google/bdict_reader.cc File third_party/hunspell/google/bdict_reader.cc (right): https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google/bdict_reader.cc#newcode788 third_party/hunspell/google/bdict_reader.cc:788: return ReplacementIterator(bdict_data_, 0, 0); // Item is empty or ...
4 years, 6 months ago (2016-06-21 18:22:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081893002/1
4 years, 6 months ago (2016-06-21 18:23:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 18:29:54 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:32:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/935d1f6af681c09dfc175535924268626f07d5fa
Cr-Commit-Position: refs/heads/master@{#401050}

Powered by Google App Engine
This is Rietveld 408576698