[Hunspell] Better handling of invalid dictionary

[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
Committed: https://crrev.com/935d1f6af681c09dfc175535924268626f07d5fa
Cr-Commit-Position: refs/heads/master@{#401050}

[groby-ooo-7-16, 2016-06-21 16:33:27]

Description was changed from

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
==========

to

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
==========

[groby-ooo-7-16, 2016-06-21 16:33:27]

groby@chromium.org changed reviewers:
+ rouslan@chromium.org

[groby-ooo-7-16, 2016-06-21 16:33:44]

Rouslan, could you please review?

[please use gerrit instead, 2016-06-21 16:35:44]

lgtm

https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google...
File third_party/hunspell/google/bdict_reader.cc (right):

https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google...
third_party/hunspell/google/bdict_reader.cc:788: return
ReplacementIterator(bdict_data_, 0, 0);  // Item is empty or invalid.
nit: {}

[groby-ooo-7-16, 2016-06-21 18:22:40]

https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google...
File third_party/hunspell/google/bdict_reader.cc (right):

https://codereview.chromium.org/2081893002/diff/1/third_party/hunspell/google...
third_party/hunspell/google/bdict_reader.cc:788: return
ReplacementIterator(bdict_data_, 0, 0);  // Item is empty or invalid.
On 2016/06/21 16:35:44, Rouslan (ツ) wrote:
> nit: {}

Keeping it consistent with the rest of the file.

[groby-ooo-7-16, 2016-06-21 18:22:45]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2016-06-21 18:23:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081893002/1

[commit-bot: I haz the power, 2016-06-21 18:29:53]

Description was changed from

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
==========

to

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
==========

[commit-bot: I haz the power, 2016-06-21 18:29:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 18:32:15]

Description was changed from

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765
==========

to

==========
[Hunspell] Better handling of invalid dictionary

When dictionary data is invalid, this code returns a default (empty)
iterator.

BUG=618040, 621765

Committed: https://crrev.com/935d1f6af681c09dfc175535924268626f07d5fa
Cr-Commit-Position: refs/heads/master@{#401050}
==========

[commit-bot: I haz the power, 2016-06-21 18:32:16]

Patchset 1 (id:??) landed as
https://crrev.com/935d1f6af681c09dfc175535924268626f07d5fa
Cr-Commit-Position: refs/heads/master@{#401050}