[Hunspell] Better handling of invalid dictionary

third_party/hunspell/google/bdict_reader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "third_party/hunspell/google/bdict_reader.h"
 
 #include <stdint.h>
 
 #include "base/logging.h"
 
@@ skipping 764 matching lines @@
 LineIterator BDictReader::GetOtherLineIterator() const {
   if (!bdict_data_ ||
       aff_header_->other_offset == 0 ||
       aff_header_->other_offset >= bdict_length_)
     return LineIterator(bdict_data_, 0, 0);  // Item is empty or invalid.
   return LineIterator(bdict_data_, bdict_length_,
                       aff_header_->other_offset);
 }
 
 ReplacementIterator BDictReader::GetReplacementIterator() const {
+  if (!bdict_data_ ||
+      aff_header_->rep_offset == 0 ||
+      aff_header_->rep_offset >= bdict_length_)
+    return ReplacementIterator(bdict_data_, 0, 0);  // Item is empty or invalid.

[please use gerrit instead, 2016/06/21 16:35:44]

nit: {}

[groby-ooo-7-16, 2016/06/21 18:22:40]

Keeping it consistent with the rest of the file.

   return ReplacementIterator(bdict_data_, bdict_length_,
                              aff_header_->rep_offset);
 }
 
 
 WordIterator BDictReader::GetAllWordIterator() const {
   NodeReader reader(bdict_data_, bdict_length_, header_->dic_offset, 0);
   return WordIterator(reader);
 }
 
 }  // namespace hunspell