Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: chrome/browser/chromeos/eol_notification.cc

Issue 2081873002: Incorporate comments in Dbus code and add Eol icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/eol_notification.cc
diff --git a/chrome/browser/chromeos/eol_notification.cc b/chrome/browser/chromeos/eol_notification.cc
index 8b5f49eb2e14b5fde57624419b074d185921ecb8..8554003ca750c972aa5533e5a271e76c6eaea2d7 100644
--- a/chrome/browser/chromeos/eol_notification.cc
+++ b/chrome/browser/chromeos/eol_notification.cc
@@ -16,7 +16,6 @@
#include "chromeos/dbus/update_engine_client.h"
#include "components/prefs/pref_service.h"
#include "grit/ash_resources.h"
-#include "third_party/cros_system_api/dbus/update_engine/dbus-constants.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -94,7 +93,7 @@ void EolNotification::CheckEolStatus() {
base::Bind(&EolNotification::OnEolStatus, weak_factory_.GetWeakPtr()));
}
-void EolNotification::OnEolStatus(int status) {
+void EolNotification::OnEolStatus(update_engine::EndOfLifeStatus status) {
status_ = status;
const int pre_eol_status =
@@ -132,8 +131,7 @@ void EolNotification::Update() {
Notification notification(
message_center::NOTIFICATION_TYPE_SIMPLE,
base::string16(), // title
- // TODO(xiaoyinh): Update the Eol icon once it's ready.
- GetEolMessage(), bundle.GetImageNamed(IDR_AURA_NOTIFICATION_DISPLAY),
+ GetEolMessage(), bundle.GetImageNamed(IDR_AURA_NOTIFICATION_EOL),
message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
kEolNotificationId),
base::string16(), // display_source

Powered by Google App Engine
This is Rietveld 408576698