Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chromeos/dbus/fake_update_engine_client.h

Issue 2081873002: Incorporate comments in Dbus code and add Eol icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_update_engine_client.h
diff --git a/chromeos/dbus/fake_update_engine_client.h b/chromeos/dbus/fake_update_engine_client.h
index a1aa3aa8cbbf152dd3e8b58943ab6e2f30a18241..d3d1e131ab6d41a45404c223c0e0d3b2460a9540 100644
--- a/chromeos/dbus/fake_update_engine_client.h
+++ b/chromeos/dbus/fake_update_engine_client.h
@@ -77,6 +77,12 @@ class FakeUpdateEngineClient : public UpdateEngineClient {
int can_rollback_call_count() const { return can_rollback_call_count_; }
private:
+ void OnGetChannel(const GetChannelCallback& callback) { callback.Run(""); }
xiyuan 2016/06/21 15:18:14 Don't inline this. Put the body in cc file.
xiaoyinh(OOO Sep 11-29) 2016/06/22 18:25:40 Done.
+
+ void OnGetEolStatus(const GetEolStatusCallback& callback) {
xiyuan 2016/06/21 15:18:14 same here.
xiaoyinh(OOO Sep 11-29) 2016/06/22 18:25:40 Done.
+ callback.Run(update_engine::EndOfLifeStatus::kSupported);
+ }
+
base::ObserverList<Observer> observers_;
std::queue<UpdateEngineClient::Status> status_queue_;
UpdateEngineClient::Status default_status_;
@@ -86,6 +92,8 @@ class FakeUpdateEngineClient : public UpdateEngineClient {
int request_update_check_call_count_;
int rollback_call_count_;
int can_rollback_call_count_;
+
+ base::WeakPtrFactory<FakeUpdateEngineClient> weak_ptr_factory_;
};
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698