Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2081733003:
[Mac/GN] Load Content Shell Framework using rpath rather than executable_path. (Closed)
|
Created:
4 years, 6 months ago by Robert Sesek Modified:
4 years, 6 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac/GN] Load Content Shell Framework using rpath rather than executable_path.
The install_name_tool step was causing overbuild, since the Helper executable's
build stamp was older than the executable file itself after install_name_tool
ran.
Using rpath solves this issue by removing the install_name_tool step and
instead lets the Helper and Main app specify their own rpath to the framework.
BUG=431177
R=mark@chromium.org
TBR=jam@chromium.org
Committed: https://crrev.com/6a8a5d0acf751cd9e0926ff36735a8311e006d91
Cr-Commit-Position: refs/heads/master@{#400862}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm.
Description was changed from ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executables build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org ========== to ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org ==========
LGTM
rsesek@chromium.org changed reviewers: + jam@chromium.org
+jam for //content OWNERS stamp
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081733003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org ========== to ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org TBR=jam@chromium.org ==========
The CQ bit was checked by dpranke@chromium.org
TBR'ing jam@ so we can get this in sooner than later.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081733003/1
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org TBR=jam@chromium.org ========== to ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org TBR=jam@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org TBR=jam@chromium.org ========== to ========== [Mac/GN] Load Content Shell Framework using rpath rather than executable_path. The install_name_tool step was causing overbuild, since the Helper executable's build stamp was older than the executable file itself after install_name_tool ran. Using rpath solves this issue by removing the install_name_tool step and instead lets the Helper and Main app specify their own rpath to the framework. BUG=431177 R=mark@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/6a8a5d0acf751cd9e0926ff36735a8311e006d91 Cr-Commit-Position: refs/heads/master@{#400862} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6a8a5d0acf751cd9e0926ff36735a8311e006d91 Cr-Commit-Position: refs/heads/master@{#400862} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
