Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2081643004: V8: switch more linux bots to mb (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+611 lines, -5 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 1 chunk +12 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 14 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 2 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json View 2 chunks +42 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json View 2 chunks +43 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json View 2 chunks +42 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json View 2 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json View 2 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gcov_coverage.json View 2 chunks +38 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json View 2 chunks +45 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json View 2 chunks +45 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json View 2 chunks +40 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json View 2 chunks +42 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json View 2 chunks +42 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json View 2 chunks +44 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
PTAL tandrii for the api change. TBR for the mb flips
4 years, 6 months ago (2016-06-21 07:58:27 UTC) #3
tandrii(chromium)
lgtm https://codereview.chromium.org/2081643004/diff/1/scripts/slave/recipe_modules/v8/api.py File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/2081643004/diff/1/scripts/slave/recipe_modules/v8/api.py#newcode418 scripts/slave/recipe_modules/v8/api.py:418: def gyp_defines_to_dict(gyp_defines): example string as comment for understanding ...
4 years, 6 months ago (2016-06-21 08:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081643004/20001
4 years, 6 months ago (2016-06-21 08:32:12 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 08:35:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/505e74b303f9f3d3cc8f...

Powered by Google App Engine
This is Rietveld 408576698