Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2081643004: V8: switch more linux bots to mb (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/builders.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index fe63252eb1085025d7fba34ef9f4ca34afe7857f..4abf3aedafd9cec869b3f042ade91e405f2a0ec2 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -416,7 +416,18 @@ class V8Api(recipe_api.RecipeApi):
"""
def gyp_defines_to_dict(gyp_defines):
- return dict(tuple(x.split('=', 1)) for x in gyp_defines.split())
+ # Example input: "foo=1 bar='buz bing'". We assume there's no '=' in the
+ # value part.
+ result = []
+ for x in gyp_defines.split():
+ kv = x.split('=', 1)
+ if len(kv) == 1:
+ # No '=' in x. It's part of a quoted string containing a space.
+ # Append it to the last value.
+ result[-1][1] += (' ' + kv[0])
+ else:
+ result.append(kv)
+ return dict(tuple(kv) for kv in result)
infra_flags = gyp_defines_to_dict(
self.m.chromium.c.gyp_env.as_jsonish()['GYP_DEFINES'])
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/builders.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698