Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2081643003: Fix the frame freezing issue observed during a config change in the H.264 decoder on Windows (Closed)

Created:
4 years, 6 months ago by ananta
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix the frame freezing issue observed during a config change in the H.264 decoder on Windows Merging to M52 We need to drain the decoder of any pending output before tearing down the instance of the decoder and recreating it during a configuration change. Draining the decoder is done as part of a Flush operation. However this is a decoder initiated flush which requires the following 1. Don't process pending input in this case as that is what caused the config change. 2. Don't notify the client about the completion of the flush operation. Added a member variable processing_config_change_ to track this state. We mimic most of the logic we have to process the pending_flush_ state when this flag is set. BUG=616349 Review-Url: https://codereview.chromium.org/2065323002 Cr-Commit-Position: refs/heads/master@{#400023} (cherry picked from commit ec68dd1bde3f2049975d8aa194525983d4a93688) Committed: https://chromium.googlesource.com/chromium/src/+/faf72f7be4cb958e249e5a6da6fdf30571487ce1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -13 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 11 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
4 years, 6 months ago (2016-06-20 20:05:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
faf72f7be4cb958e249e5a6da6fdf30571487ce1.

Powered by Google App Engine
This is Rietveld 408576698