Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2065323002: Fix the frame freezing issue observed during a config change in the H.264 decoder on Windows (Closed)

Created:
4 years, 6 months ago by ananta
Modified:
4 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the frame freezing issue observed during a config change in the H.264 decoder on Windows We need to drain the decoder of any pending output before tearing down the instance of the decoder and recreating it during a configuration change. Draining the decoder is done as part of a Flush operation. However this is a decoder initiated flush which requires the following 1. Don't process pending input in this case as that is what caused the config change. 2. Don't notify the client about the completion of the flush operation. Added a member variable processing_config_change_ to track this state. We mimic most of the logic we have to process the pending_flush_ state when this flag is set. BUG=616349 Committed: https://crrev.com/ec68dd1bde3f2049975d8aa194525983d4a93688 Cr-Commit-Position: refs/heads/master@{#400023}

Patch Set 1 #

Patch Set 2 : Process flush during config change as a regular flush #

Patch Set 3 : Reset the processing_config_changed_ flag during a flush #

Patch Set 4 : Update comment #

Patch Set 5 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -13 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 2 3 4 11 chunks +38 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
ananta
4 years, 6 months ago (2016-06-15 02:53:39 UTC) #2
sandersd (OOO until July 31)
I didn't re-read the entire state machine so I wanted to confirm with you that ...
4 years, 6 months ago (2016-06-15 18:50:55 UTC) #3
ananta
On 2016/06/15 18:50:55, sandersd wrote: > I didn't re-read the entire state machine so I ...
4 years, 6 months ago (2016-06-15 20:00:51 UTC) #4
ananta
As per our discussion update the comment in the Flush function to look into whether ...
4 years, 6 months ago (2016-06-15 20:39:40 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years, 6 months ago (2016-06-15 20:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065323002/80001
4 years, 6 months ago (2016-06-15 21:12:29 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-15 22:09:12 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 22:09:16 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 22:12:38 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ec68dd1bde3f2049975d8aa194525983d4a93688
Cr-Commit-Position: refs/heads/master@{#400023}

Powered by Google App Engine
This is Rietveld 408576698