Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2081633002: Reject invert for outline-color at parse time. (Closed)

Created:
4 years, 6 months ago by rune
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject invert for outline-color at parse time. We don't support invert as outline-color, so we should drop it at parse time as per spec[1]. Added test to check that the initial value of outline-color is the computed value of currentColor. Gecko also drops declarations with invert for outline-color. [1] https://drafts.csswg.org/css2/ui.html#value-def-invert R=timloh@chromium.org BUG=620399 Committed: https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84 Cr-Commit-Position: refs/heads/master@{#400902}

Patch Set 1 #

Patch Set 2 : New attempt. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/outline-currentcolor.html View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/outline-currentcolor-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/outline-invert.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TextLinkColors.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081633002/1
4 years, 6 months ago (2016-06-20 08:45:24 UTC) #2
rune
ptal
4 years, 6 months ago (2016-06-20 08:48:13 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/83625)
4 years, 6 months ago (2016-06-20 08:54:23 UTC) #5
rune
I misread the spec. We should reject the whole declaration at parse time if we ...
4 years, 6 months ago (2016-06-20 09:02:42 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081633002/20001
4 years, 6 months ago (2016-06-20 09:57:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/230738)
4 years, 6 months ago (2016-06-20 11:13:46 UTC) #10
rune
Ready for review again. The chromeos failure looks unrelated.
4 years, 6 months ago (2016-06-20 11:18:37 UTC) #12
Timothy Loh
On 2016/06/20 11:18:37, rune wrote: > Ready for review again. The chromeos failure looks unrelated. ...
4 years, 6 months ago (2016-06-21 00:13:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081633002/20001
4 years, 6 months ago (2016-06-21 05:18:47 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 05:49:48 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 05:51:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e71d3d9b4687a515e0aca0089a46cc8df84ce84
Cr-Commit-Position: refs/heads/master@{#400902}

Powered by Google App Engine
This is Rietveld 408576698