Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/Source/core/dom/TextLinkColors.cpp

Issue 2081633002: Reject invert for outline-color at parse time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New attempt. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/TextLinkColors.cpp
diff --git a/third_party/WebKit/Source/core/dom/TextLinkColors.cpp b/third_party/WebKit/Source/core/dom/TextLinkColors.cpp
index 0bf89d1040448a2648409265af6c2736fe642c28..dba4f72acec32989c06568b3386ad706277b66c2 100644
--- a/third_party/WebKit/Source/core/dom/TextLinkColors.cpp
+++ b/third_party/WebKit/Source/core/dom/TextLinkColors.cpp
@@ -65,7 +65,8 @@ Color TextLinkColors::colorFromCSSValue(const CSSValue& value, Color currentColo
CSSValueID valueID = toCSSPrimitiveValue(value).getValueID();
switch (valueID) {
- case 0:
+ case CSSValueInvalid:
+ NOTREACHED();
return Color();
case CSSValueInternalQuirkInherit:
return textColor();
@@ -75,7 +76,6 @@ Color TextLinkColors::colorFromCSSValue(const CSSValue& value, Color currentColo
return activeLinkColor();
case CSSValueWebkitFocusRingColor:
return LayoutTheme::theme().focusRingColor();
- case CSSValueInvert: // We don't support outline-color: invert
case CSSValueCurrentcolor:
return currentColor;
default:
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698