Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html

Issue 2081513002: Remove video-test.js dependency from track-cue-rendering* tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add reference tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html
index 42d6ba56a835d639c378b77ba6e8af55427903fa..4af82ce50e2ac77d1eb2e12925185f00f42b2ab2 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html
@@ -1,37 +1,17 @@
<!DOCTYPE html>
-<html lang="ja">
- <head>
- <meta charset="utf-8">
- <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<title>Test rendering vertical line-positioned cues with Japanese text.</title>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<script src="../media-file.js"></script>
+<video>
+ <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="captions" default>
+</video>
+<script>
+testRunner.waitUntilDone();
fs 2016/07/19 14:17:05 I'd suggest moving this down to just before settin
+var video = document.querySelector("video");
+video.src = findMediaFile("video", "../content/test");
+video.currentTime = 0.75;
- <script src=../media-file.js></script>
-
- <script>
- var requirePixelDump = true;
-
- function loaded()
- {
- consoleWrite("Rendering vertical line-positioned cues with Japanese text.");
- findMediaElement();
-
- testTrack = document.querySelector('track');
- video.src = findMediaFile('video', '../content/test');
-
- waitForEvent('seeked', endTest);
- waitForEvent('canplaythrough', function() {
- video.currentTime = .75;
- });
- }
-
- </script>
-
- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=../video-test.js></script>
- </head>
- <body onload="loaded()">
- <video>
- <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="captions" default>
- </video>
- </body>
-</html>
+video.onloadeddata = function() {
+ testRunner.notifyDone();
+};
+</script>

Powered by Google App Engine
This is Rietveld 408576698