third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html - Issue 2081513002: Remove video-test.js dependency from track-cue-rendering* tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical.html

Issue 2081513002: Remove video-test.js dependency from track-cue-rendering* tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add reference tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-rendering-horizontal-expected.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-vertical-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html lang="ja">	2 <title>Test rendering vertical line-positioned cues with Japanese text.</title>

3 <head>	3 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

4 <meta charset="utf-8">	4 <script src="../media-file.js"></script>

5 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	5 <video>

	6 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="captions" default>

	7 </video>

	8 <script>

	9 testRunner.waitUntilDone();
	fs 2016/07/19 14:17:05 I'd suggest moving this down to just before settin I'd suggest moving this down to just before setting up the event-handler that calls notifyDone. This way the test will work better even when there's no testRunner. Same in the *-horizontal test.
	10 var video = document.querySelector("video");

	11 video.src = findMediaFile("video", "../content/test");

	12 video.currentTime = 0.75;

6	13

7 <script src=../media-file.js></script>	14 video.onloadeddata = function() {

8	15 testRunner.notifyDone();

9 <script>	16 };

10 var requirePixelDump = true;	17 </script>

11

12 function loaded()

13 {

14 consoleWrite("Rendering vertical line-positioned cues with Japanese text.");

15 findMediaElement();

16

17 testTrack = document.querySelector('track');

18 video.src = findMediaFile('video', '../content/test');

19

20 waitForEvent('seeked', endTest);

21 waitForEvent('canplaythrough', function() {

22 video.currentTime = .75;

23 });

24 }

25

26 </script>

27

28 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

29 (Please avoid writing new tests using video-test.js) -->

30 <script src=../video-test.js></script>

31 </head>

32 <body onload="loaded()">

33 <video>

34 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="ca ptions" default>

35 </video>

36 </body>

37 </html>

OLD	NEW