[MD settings] keep drawer open when toggling advanced page

[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813
Cr-Commit-Position: refs/heads/master@{#401711}

[dschuyler, 2016-06-21 21:08:37]

Description was changed from

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when a page of settings sections
is opened/closed in the side nav menu. The advanced page is the only
page that opens/closes at the moment.

BUG=613708
==========

to

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when a page of settings sections
is opened/closed in the side nav menu. The advanced page is the only
page that opens/closes at the moment.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-06-21 21:09:24]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dschuyler, 2016-06-21 21:15:10]

Description was changed from

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when a page of settings sections
is opened/closed in the side nav menu. The advanced page is the only
page that opens/closes at the moment.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-06-22 02:43:01]

https://codereview.chromium.org/2081393002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2081393002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:39: if
(event.detail.item != this.$$('app-drawer settings-menu').$.advancedPage)
what about event.detail.item.id != 'advancedPage'?

[dschuyler, 2016-06-22 23:27:38]

Good suggestion, thanks.

https://codereview.chromium.org/2081393002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2081393002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:39: if
(event.detail.item != this.$$('app-drawer settings-menu').$.advancedPage)
On 2016/06/22 02:43:00, michaelpg wrote:
> what about event.detail.item.id != 'advancedPage'?

Done.

[michaelpg, 2016-06-22 23:47:03]

lgtm

[dschuyler, 2016-06-23 20:33:03]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-06-23 20:33:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081393002/40001

[commit-bot: I haz the power, 2016-06-23 20:47:05]

Description was changed from

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-23 20:47:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 20:50:11]

Description was changed from

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] keep drawer open when toggling advanced page

This CL stops the drawer from closing when the advanced page
is opened/closed in the side nav menu.

BUG=613708
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813
Cr-Commit-Position: refs/heads/master@{#401711}
==========

[commit-bot: I haz the power, 2016-06-23 20:50:12]

Patchset 3 (id:??) landed as
https://crrev.com/b3cecfd7ecca13a3ed763c43b1a3680c9ca1c813
Cr-Commit-Position: refs/heads/master@{#401711}