Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2081393002: [MD settings] keep drawer open when toggling advanced page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review change Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index a6b1008786877c440740f457859cfd2ace456965..1275cf1740d3da50eae57e49394f9e9f97750f51 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -31,9 +31,13 @@ Polymer({
'sideNav.iron-activate': 'onIronActivate_',
},
- /** @private */
- onIronActivate_: function() {
- this.$$('app-drawer').close();
+ /**
+ * @param {Event} event
+ * @private
+ */
+ onIronActivate_: function(event) {
+ if (event.detail.item.id != 'advancedPage')
+ this.$$('app-drawer').close();
},
/** @private */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698